sunhelly commented on code in PR #4568:
URL: https://github.com/apache/hbase/pull/4568#discussion_r904603247
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java:
##########
@@ -148,12 +147,10 @@ private void createCompactionExecutors() {
this.longCompactions = new ThreadPoolExecutor(largeThreads, largeThreads,
60, TimeUnit.SECONDS,
stealJobQueue,
new ThreadFactoryBuilder().setNameFormat(n +
"-longCompactions-%d").setDaemon(true).build());
- this.longCompactions.setRejectedExecutionHandler(new Rejection());
this.longCompactions.prestartAllCoreThreads();
this.shortCompactions = new ThreadPoolExecutor(smallThreads, smallThreads,
60, TimeUnit.SECONDS,
stealJobQueue.getStealFromQueue(),
new ThreadFactoryBuilder().setNameFormat(n +
"-shortCompactions-%d").setDaemon(true).build());
- this.shortCompactions.setRejectedExecutionHandler(new Rejection());
}
Review Comment:
Remove the reject handler since the stealJobQueue here is unbounded. The
reject handler may brings some confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
