[ 
https://issues.apache.org/jira/browse/HBASE-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401721#comment-13401721
 ] 

Zhihong Ted Yu commented on HBASE-6170:
---------------------------------------

Minor comment:
{code}
+   * The lease timeout period for client scans (milliseconds).
+   */
+  private final int scannerLeaseTimeoutPeriod;
{code}
'client scans' -> 'client scanners'
{code}
-    this.leases = new Leases((int) conf.getLong(
+    this.leases = new Leases(conf.getInt(
{code}
I would suggest changing the getInt() calls back to getLong().
                
> Timeouts for row lock and scan should be separate
> -------------------------------------------------
>
>                 Key: HBASE-6170
>                 URL: https://issues.apache.org/jira/browse/HBASE-6170
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.94.0
>            Reporter: Otis Gospodnetic
>            Assignee: Chris Trezzo
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6170v1.patch, HBASE-6170v1.patch, 
> HBASE-6170v1.patch
>
>
> Apparently the timeout used for row locking and for scanning is global.  It 
> would be better to have two separate timeouts.
> (opening the issue to make Lars George happy)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to