virajjasani commented on PR #4596:
URL: https://github.com/apache/hbase/pull/4596#issuecomment-1174653213

   Do you think `handlerRemoved` should be overridden in 
`SaslChallengeDecoder`? (though `ByteToMessageDecoder` has `handlerRemoved` 
already)
   
   Somehow I feel leak needs to be handled in decoder as per the below logs, I 
might be wrong though.
   ```
   2022-07-05 05:59:52,308 ERROR [S-EventLoopGroup-1-4] 
util.ResourceLeakDetector - 
apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:510)
        
org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:449)
        
org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to