bbeaudreault commented on code in PR #4595:
URL: https://github.com/apache/hbase/pull/4595#discussion_r914040557
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java:
##########
@@ -619,4 +615,13 @@ static void updateStats(Optional<ServerStatisticTracker>
optStats,
metrics -> ResultStatsUtil.updateStats(metrics, serverName,
regionName, regionLoadStats));
});
}
+
+ public static AsyncConnection createAsyncConnection(Configuration conf)
throws IOException {
+ return FutureUtils.get(ConnectionFactory.createAsyncConnection(conf));
+ }
Review Comment:
What's the benefit of this, versus just doing
`ConnectionFactory.createAsyncConnection(conf).get()` in ReplicationSink?
And do we need both of these methods, looks like just one is used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
