[ 
https://issues.apache.org/jira/browse/HBASE-26950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564643#comment-17564643
 ] 

Hudson commented on HBASE-26950:
--------------------------------

Results for branch branch-2
        [build #588 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/588/]: 
(/) *{color:green}+1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/588/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/588/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/588/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/588/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Use AsyncConnection in ReplicationSink
> --------------------------------------
>
>                 Key: HBASE-26950
>                 URL: https://issues.apache.org/jira/browse/HBASE-26950
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.4.11
>            Reporter: Bryan Beaudreault
>            Assignee: chenglei
>            Priority: Major
>              Labels: branch-2, replication
>             Fix For: 2.5.0, 2.6.0
>
>
> We don't need to necessarily rewrite ReplicationSink to work fully async. I 
> think it would simply benefit from ConnectionFactory.createAsyncConnection 
> instead of ConnectionFactory.createConnection.
> The reasons for this are:
>  * AsyncConnection is the more modern implementation, the only implementation 
> in master, and where most of the efforts will be going forward.
>  * ReplicationSink only does batch calls, and batch calls are done with 
> AsyncProcess. It's likely that the native AsyncTable is better than 
> AsyncProcess for this.
>  ** One specific example, AsyncProcess calls findAllLocationsOrFail 
> sequentially for all actions in a batch. This can take quite a while with the 
> default replication batch size of 5k, if actions are spread across many 
> regions. In AsyncTable, these calls are done in parallel



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to