Apache9 commented on code in PR #4533:
URL: https://github.com/apache/hbase/pull/4533#discussion_r917899224
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java:
##########
@@ -60,6 +60,17 @@ public final class TableDescriptorChecker {
private TableDescriptorChecker() {
}
+ private static boolean shouldSanityCheck(final Configuration conf, final
TableDescriptor td) {
+ if (conf.getBoolean(TABLE_SANITY_CHECKS, DEFAULT_TABLE_SANITY_CHECKS)) {
+ return true;
+ }
+ String tableVal = td.getValue(TABLE_SANITY_CHECKS);
Review Comment:
The first line in the sanityCheck method has aleady one the trick for you?
It creates a CompoundConfiguration with td.getValues override the configs in
Configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
