apurtell opened a new pull request, #4613: URL: https://github.com/apache/hbase/pull/4613
Replace `BufferChain#write(channel,int)` with a simpler `#write(channel)` implementation that does not attempt to "chunk" data to be written. This method was used exclusively by `SimpleRpcServer`. The code was unnecessarily complex and caused short writes when values were large, which were exposed by MAC verification failures when SASL is enabled, so was corrected and simplified. Any difference in performance from this change will be limited to `SimpleRpcServer`. Testing under load confirms the fix and does not show significant regression. `SimpleRpcServer` and its related code is now also marked as `@Deprecated`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
