bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r918874083
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java:
##########
@@ -181,4 +204,80 @@ public int getNumOpenConnections() {
// allChannels also contains the server channel, so exclude that from the
count.
return channelsCount > 0 ? channelsCount - 1 : channelsCount;
}
+
+ private synchronized void initSSL(ChannelPipeline p, boolean
supportPlaintext) throws
+ X509Exception {
+ SslContext nettySslContext;
+
+ SSLContextAndOptions sslContextAndOptions =
x509Util.getDefaultSSLContextAndOptions();
+ nettySslContext = sslContextAndOptions
+ .createNettyJdkSslContext(sslContextAndOptions.getSSLContext(), false);
+
+ if (supportPlaintext) {
Review Comment:
I thought more about this request -- it'd be nice, but more complicated than
the scope of this issue. The problem is that hbase servers publish their listen
port to ZK/meta for clients to find. If we started listening on 2 ports, we
might need to either make a change to `ServerName` to allow 2 ports, or add new
configs in the client for overriding the port to use. Neither really fits in
the scope of this issue, so I'm resolving this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
