[
https://issues.apache.org/jira/browse/HBASE-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402421#comment-13402421
]
Devaraj Das commented on HBASE-6279:
------------------------------------
So in those cases where the interface extends proto-generated code, it seems
like the RpcController cannot be avoided (at least I don't know if there is a
way). For example, see AdminProtocol (in trunk) - it extends
AdminService.BlockingInterface...
But in the cases where the interface is written by hand (for example,
HMasterInterface) the RpcController argument can be avoided.
It makes sense to extend the proto-generated code to reduce maintenance burden.
But yeah, then the RpcController will stick around..
[Meant to reply back yesterday, but forgot. Sorry]
> Remove the RpcController argument from the PB methods' signatures
> -----------------------------------------------------------------
>
> Key: HBASE-6279
> URL: https://issues.apache.org/jira/browse/HBASE-6279
> Project: HBase
> Issue Type: Bug
> Reporter: Devaraj Das
>
> I don't see a reason for having the RPC methods (like HMasterInterface)
> define methods with the RpcController argument (which is always passed as
> null during invocation).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
