apurtell commented on code in PR #4626:
URL: https://github.com/apache/hbase/pull/4626#discussion_r923915134
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/CacheEvictionStats.java:
##########
@@ -28,7 +29,7 @@ public final class CacheEvictionStats {
private final long evictedBlocks;
private final long maxCacheSize;
- private final Map<byte[], Throwable> exceptions;
+ private final IdentityHashMap<byte[], Throwable> exceptions;
Review Comment:
The warning here is the one that suggests maps and identity keys should not
be mixed... that if the keys use object identity, the map type should be
IdentityHashMap. It seems minor, but correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]