virajjasani commented on code in PR #4628:
URL: https://github.com/apache/hbase/pull/4628#discussion_r923995276
##########
pom.xml:
##########
@@ -2715,6 +2715,27 @@
<!-- spotless manve plugin does not allow empty here, so use \n
-->
<replacement>\n</replacement>
</replaceRegex>
+ <!--
+ e.g., rewrite
+ /** @return blabla */
+ or
+ /**
+ * @return blabla
+ */
+ to
+ /** Returns blabla */
+ See https://errorprone.info/bugpattern/FutureReturnValueIgnored
+ -->
+ <replaceRegex>
+ <name>Purge single returns tag multi line</name>
+ <searchRegex>(?m)^ */\*\*\n *\* *@return *(.*) *\n
*\*/$</searchRegex>
+ <replacement>/** Returns $1 */</replacement>
+ </replaceRegex>
+ <replaceRegex>
+ <name>Purge single returns tag single line</name>
+ <searchRegex>^ */\*\* *@return *(.*) *\*/$</searchRegex>
+ <replacement>/** Returns $1 */</replacement>
+ </replaceRegex>
<!-- apply a specific flavor -->
Review Comment:
Sounds good, I think combining with this PR was also fine, I just wanted to
know whether this regex was going to be effective with version bump. But now
that this PR is merged, let's bump it now with HBASE-27221. Thanks for this
nice work @Apache9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]