apurtell commented on code in PR #4644:
URL: https://github.com/apache/hbase/pull/4644#discussion_r929386431
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/CompactType.java:
##########
@@ -26,9 +26,7 @@
@InterfaceAudience.Public
public enum CompactType {
- NORMAL(0),
- MOB(1);
+ NORMAL,
Review Comment:
Correct, the value passed to the constructor was not exposed. Someone might
wonder if CompactType#ordinal would return these special values but it would
not.
In other places we pass such enums an integer value via its constructor to
return from a `getCode` or similarly named method but this pattern was
incompletely applied here in a way that it safe to remove ... and causes an
error-prone warning, last but not least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
