apurtell commented on code in PR #4645:
URL: https://github.com/apache/hbase/pull/4645#discussion_r929413626
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java:
##########
@@ -271,7 +272,7 @@ public byte[] encodeData() {
if (this.meta.isIncludesMvcc()) {
memstoreTS = ByteBufferUtils.readVLong(in);
}
- kv = new KeyValue(in.array(), kvOffset,
+ kv = new KeyValue(in.array(), in.arrayOffset() + kvOffset,
Review Comment:
I think we are safe at this time because we aren't `slice()`ing buffers, not
yet. This will prevent future issues though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
