Apache9 commented on code in PR #4645:
URL: https://github.com/apache/hbase/pull/4645#discussion_r929513282
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java:
##########
@@ -279,14 +278,14 @@ private Cell toOffheapCell(ByteBuffer valAndTagsBuffer,
int vOffset,
protected static class OnheapDecodedCell implements ExtendedCell {
private static final long FIXED_OVERHEAD = ClassSize.align(ClassSize.OBJECT
+ (3 * ClassSize.REFERENCE) + (2 * Bytes.SIZEOF_LONG) + (7 *
Bytes.SIZEOF_INT)
- + (Bytes.SIZEOF_SHORT) + (2 * Bytes.SIZEOF_BYTE) + (3 *
ClassSize.ARRAY));
+ + Bytes.SIZEOF_SHORT + (2 * Bytes.SIZEOF_BYTE) + (3 * ClassSize.ARRAY));
private byte[] keyOnlyBuffer;
private short rowLength;
private int familyOffset;
private byte familyLength;
private int qualifierOffset;
private int qualifierLength;
- private long timestamp;
+ private long timeStamp;
Review Comment:
Searched our code base, there are bunch of mixed TimeStamp and Timestamp
usages... We even have code like this:
`.setTimestampsOfLastAppliedOp(rls.getTimeStampsOfLastAppliedOp())`
And in the same protobuf message, we have mixed style of timestamps...
```
message ReplicationLoadSink {
required uint64 ageOfLastAppliedOp = 1;
required uint64 timeStampsOfLastAppliedOp = 2;
// The below two were added after hbase-2.0.0 went out. They have to be
added as 'optional' else
// we break upgrades; old RegionServers reporting in w/ old forms of this
message will fail to
// deserialize on the new Master. See HBASE-25234
optional uint64 timestampStarted = 3;
optional uint64 totalOpsProcessed = 4;
}
```
So I tend to leave it as it for now. Maybe we should start a discussion
thread on the dev list on how to better fix these problems...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
