ndimiduk commented on code in PR #4572:
URL: https://github.com/apache/hbase/pull/4572#discussion_r934448474
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##########
@@ -1256,11 +1257,12 @@ public HFileBlock readBlock(long dataBlockOffset, long
onDiskBlockSize, final bo
BlockCacheKey cacheKey =
new BlockCacheKey(name, dataBlockOffset, this.isPrimaryReplicaReader(),
expectedBlockType);
+ Attributes attributes = Attributes.of(BLOCK_CACHE_KEY_KEY,
cacheKey.toString());
boolean useLock = false;
IdLock.Entry lockEntry = null;
- Span span =
TraceUtil.getGlobalTracer().spanBuilder("HFileReaderImpl.readBlock").startSpan();
- try (Scope traceScope = span.makeCurrent()) {
+ final Span span = Span.current();
Review Comment:
For the curious, a benchmark was performed and posted over on
https://github.com/apache/hbase/pull/4601#issuecomment-1195598276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
