Apache9 commented on code in PR #4678:
URL: https://github.com/apache/hbase/pull/4678#discussion_r937465581
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStatus.java:
##########
@@ -139,6 +139,7 @@ private List<ReplicationLoadSource> waitOnMetricsReport(int
greaterThan, ServerN
metrics.getLiveServerMetrics().get(serverName).getReplicationLoadSourceList();
while (list.size() <= greaterThan) {
Threads.sleep(1000);
+ list =
metrics.getLiveServerMetrics().get(serverName).getReplicationLoadSourceList();
Review Comment:
This is still incorrect...
We need to call hbaseAdmin.getClusterMetrics every time when checking...
And here we'd better use the waitFor method to limit the max wait time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
