alexdongli0829 commented on code in PR #4661:
URL: https://github.com/apache/hbase/pull/4661#discussion_r943319819
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##########
@@ -2431,11 +2431,35 @@ private static boolean isCatalogTable(final TableName
tableName) {
return tableName.equals(TableName.META_TABLE_NAME);
}
+ private void checkSnapshot(TableName tableName, boolean archive) throws
IOException {
+ /*
+ * If decide to delete the table without archive, need to make sure the
table has no snapshot
+ * Meanwhile, the check will scan the snapshots which will do list and
open, if there is lots of
+ * snapshot, the performance may be impacted, should evaluate the
performance between directly
+ * archive and snapshot scan TODO: find some any way to get if the table
snapshotted or not
+ */
+ if (!archive) {
Review Comment:
@Apache9 Thanks so much for your time. The thought is because there will be
no archive for all the hfiles, so if there are any snapshots, the snapshots
will be broken if any refer for the hfiles, so to avoid the broken, I made the
check before conduct the actual delete without archive, make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
