[ 
https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403654#comment-13403654
 ] 

Hadoop QA commented on HBASE-6039:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12533922/HBASE-6039.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

     -1 core tests.  The patch failed these unit tests:
     

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2289//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2289//console

This message is automatically generated.
                
> Remove HMasterInterface and replace with something similar to 
> RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-6039
>                 URL: https://issues.apache.org/jira/browse/HBASE-6039
>             Project: HBase
>          Issue Type: Task
>          Components: ipc, master
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6039.patch
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either 
> declare a new class for the representation (similar to 
> RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. 
> What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to