rajeshbabu created HBASE-6293:
---------------------------------

             Summary: HMaster does not go down while splitting logs even if 
explicit shutdown is called.
                 Key: HBASE-6293
                 URL: https://issues.apache.org/jira/browse/HBASE-6293
             Project: HBase
          Issue Type: Bug
    Affects Versions: 0.94.0, 0.92.1
            Reporter: rajeshbabu
            Assignee: rajeshbabu
             Fix For: 0.92.2, 0.96.0, 0.94.1


When master starts up and tries to do splitlog, in case of any error we try to 
do that infinitely in a loop until it succeeds.
But now if we get a shutdown call, inside SplitLogManager
{code}
          if (stopper.isStopped()) {
            LOG.warn("Stopped while waiting for log splits to be completed");
            return;
          }
{code}
Here we know that the master has stopped.  As the task may not be completed now
{code}
 if (batch.done != batch.installed) {
      batch.isDead = true;
      tot_mgr_log_split_batch_err.incrementAndGet();
      LOG.warn("error while splitting logs in " + logDirs +
      " installed = " + batch.installed + " but only " + batch.done + " done");
      throw new IOException("error or interrupt while splitting logs in "
          + logDirs + " Task = " + batch);
    }
{code} 
we throw an exception.  In MasterFileSystem.splitLogAfterStartup() we don't 
check if the master is stopped and we try continously. 


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to