Apache9 commented on code in PR #4713:
URL: https://github.com/apache/hbase/pull/4713#discussion_r951545087
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java:
##########
@@ -181,6 +184,19 @@ public RegionMoverBuilder(String hostname, Configuration
conf) {
} else {
this.port = conf.getInt(HConstants.REGIONSERVER_PORT,
HConstants.DEFAULT_REGIONSERVER_PORT);
}
+
+ // if use-ip is enabled, we will resolve the hostname to ip to ensure
that the RegionMover
+ // logic can be executed normally, see HBASE-27304 for details.
+ boolean useIp =
conf.getBoolean(HConstants.HBASE_SERVER_USEIP_ENABLED_KEY,
Review Comment:
This is a tool? Can we get the hostname/ip by accessing the hbase cluster,
instead of relying on the configuration? What if the configuration mismatches?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
