sunhelly commented on code in PR #4725:
URL: https://github.com/apache/hbase/pull/4725#discussion_r955705347
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java:
##########
@@ -145,15 +144,15 @@ private void createCompactionExecutors() {
final String n = Thread.currentThread().getName();
StealJobQueue<Runnable> stealJobQueue = new
StealJobQueue<Runnable>(COMPARATOR);
+ // Since the StealJobQueue is unbounded, we need not to set the
RejectedExecutionHandler for
Review Comment:
Actually the max size of StealJobQueue is bouded by the VM limit of an
array, and the OOM exception occurs before the rejection handler. So
StealJobQueue is equivalent to be unbounded. I think the RejectionHandler may
bring some confusions and make the codes a little puzzle.
I will seperate the removing the rejection handler here in another issue.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
