Apache9 commented on code in PR #4729:
URL: https://github.com/apache/hbase/pull/4729#discussion_r959304021
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncBatchRpcRetryingCaller.java:
##########
@@ -487,6 +487,10 @@ private void tryResubmit(Stream<Action> actions, int
tries, boolean immediately,
} else {
delayNs = getPauseTime(pauseNsToUse, tries - 1);
}
+ Optional<MetricsConnection> metrics = conn.getConnectionMetrics();
Review Comment:
Move this inside the below if condition block?
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:
##########
@@ -139,6 +139,10 @@ private void tryScheduleRetry(Throwable error) {
delayNs = getPauseTime(pauseNsToUse, tries - 1);
}
tries++;
+ Optional<MetricsConnection> metrics = conn.getConnectionMetrics();
Review Comment:
Ditto.
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncScanSingleRegionRpcRetryingCaller.java:
##########
@@ -441,6 +444,10 @@ private void onError(Throwable error) {
return;
}
tries++;
+ Optional<MetricsConnection> metrics = conn.getConnectionMetrics();
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
