[ 
https://issues.apache.org/jira/browse/HBASE-27362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chenglei updated HBASE-27362:
-----------------------------
    Description: 
When compaction is disabled, {{CompactSplit.compactionsEnabled}} is set to 
false and {{CompactSplit.longCompactions}} and 
{{CompactSplit.shortCompactions}} is shutdown.
But for  {{CompactSplit.requestCompactionInternal}} , it only check 
{{CompactSplit.compactionsEnabled}} in {{CompactSplit.selectCompaction}}, when 
{{selectNow}} is false,  {{CompactSplit.selectCompaction}}  is not invoked and 
would submit the  compaction task to {{CompactSplit.shortCompactions}},after 
HBASE-27332, because {{CompactSplit.shortCompactions}} is shut down, 
{{RejectedExecutionException}} would throw.

  was:
When compaction is disabled, {{CompactSplit.compactionsEnabled}} is set to 
false and {{CompactSplit.longCompactions}} and 
{{CompactSplit.shortCompactions}} is shutdown,
but {{CompactSplit.requestCompactionInternal}}  only check 
{{CompactSplit.compactionsEnabled}} in {{CompactSplit.selectCompaction}}, when 
{{selectNow}} is false,  {{CompactSplit.selectCompaction}}  is not invoked and 
submit the  compaction task to {{CompactSplit.shortCompactions}},after 
HBASE-27332, because {{CompactSplit.shortCompactions}} is shut down, 
{{RejectedExecutionException}} would throw


> CompactSplit.requestCompactionInternal may bypass CompactionsEnabled check
> --------------------------------------------------------------------------
>
>                 Key: HBASE-27362
>                 URL: https://issues.apache.org/jira/browse/HBASE-27362
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>    Affects Versions: 3.0.0-alpha-3
>            Reporter: chenglei
>            Priority: Major
>
> When compaction is disabled, {{CompactSplit.compactionsEnabled}} is set to 
> false and {{CompactSplit.longCompactions}} and 
> {{CompactSplit.shortCompactions}} is shutdown.
> But for  {{CompactSplit.requestCompactionInternal}} , it only check 
> {{CompactSplit.compactionsEnabled}} in {{CompactSplit.selectCompaction}}, 
> when {{selectNow}} is false,  {{CompactSplit.selectCompaction}}  is not 
> invoked and would submit the  compaction task to 
> {{CompactSplit.shortCompactions}},after HBASE-27332, because 
> {{CompactSplit.shortCompactions}} is shut down, 
> {{RejectedExecutionException}} would throw.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to