2005hithlj commented on PR #4780: URL: https://github.com/apache/hbase/pull/4780#issuecomment-1247507385
> > > > I think we should add the check in AsyncBufferedMutator? BufferedMutator is just a delegation of AsyncBufferedMutator. > > > > @Apache9 sir. Thanks for your review. > > > > Although BufferedMutator is a delegation of AsyncBufferedMutator, but BufferedMutatorOverAsyncBufferedMutator#mutate does not directly call AsyncBufferedMutator#mutate, so it needs to be done in both BufferedMutatorOverAsyncBufferedMutator#mutate and AsyncBufferedMutator#mutate. > > > > And I did it in the new commit. > > > > > > But finally they will go into the mutate(List) method? We just need to add checks there? According to the call chain, the check logic should be added to the AsyncBufferedMutatorImpl#mutate(List) method. However, AsyncBufferedMutatorImpl#mutate(List) is a public api, and there is no description of the mutate type restriction in the comments. Besides, AsyncBufferedMutatorImpl#mutate(List) will call the AsyncTable#batch(List) method, which supports the mutation types including Get, Put, Delete, Increment, Append, and RowMutations, so we should not add the check logic to the AsyncBufferedMutatorImpl#mutate(List). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
