[ 
https://issues.apache.org/jira/browse/HBASE-27368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605610#comment-17605610
 ] 

Hudson commented on HBASE-27368:
--------------------------------

Results for branch branch-2.4
        [build #425 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/425/]:
 (x) *{color:red}-1 overall{color}*
----
details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/425/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/425/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/425/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/425/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Do not need to throw IllegalStateException when peer is not active in 
> ReplicationSource.initialize
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-27368
>                 URL: https://issues.apache.org/jira/browse/HBASE-27368
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver, Replication
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> The only place where we can reset the sourceRunning flag to false is in 
> terminate method, where we want to stop the replication source. And we 
> already have a interrupted state check in the initialize method to not throw 
> IllegalStateException when peer is terminating, so I think here we could just 
> do not throw IllegalStateExeption at all.
> The reason why the interrupted state check does not work is that, in 
> FutureUtils.get, we will wrap InterruptedException with 
> InterruptedIOException, without restoring the interrupted state, but the 
> upper layer does not treat InterruptedIOException specially so the 
> interrupted state is lost. But anway, I do not think we should rely on the 
> interrupted state to determine whether we should abort the region server...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to