[ 
https://issues.apache.org/jira/browse/HBASE-6265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404944#comment-13404944
 ] 

Lars George commented on HBASE-6265:
------------------------------------

Just as a comment, the two -1's from Hadoop QA are bogus. The Javac test simply 
counts the occurrences of lines starting with "Warning", which in this case has 
one more but unrelated to the patch. 

As for the Findbugs, this is stuck with the file tracking the expected findbugs 
warnings not being updated. All the recent builds have the same -1. 

We should create an issue to fix those two deficiencies in the QA script.
                
> Calling getTimestamp() on a KV in cp.prePut() causes KV not to be flushed
> -------------------------------------------------------------------------
>
>                 Key: HBASE-6265
>                 URL: https://issues.apache.org/jira/browse/HBASE-6265
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.92.0, 0.94.0, 0.96.0
>            Reporter: Lars George
>            Assignee: Lars George
>            Priority: Critical
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: HBASE-6265-0.92.patch, HBASE-6265-0.94.patch, 
> HBASE-6265-v2.patch, HBASE-6265-v3.patch, HBASE-6265.patch
>
>
> There is an issue when you call getTimestamp() on any KV handed into a 
> Coprocessor's prePut(). It initializes the internal "timestampCache" 
> variable. 
> When you then pass it to the normal processing, the region server sets the 
> time to the server time in case you have left it unset from the client side 
> (updateLatestStamp() call). 
> The TimeRangeTracker then calls getTimestamp() later on to see if it has to 
> include the KV, but instead of getting the proper time it sees the cached 
> timestamp from the prePut() call.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to