Apache9 commented on code in PR #4827:
URL: https://github.com/apache/hbase/pull/4827#discussion_r993050289
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/SystemTableWALEntryFilter.java:
##########
@@ -17,16 +17,24 @@
*/
package org.apache.hadoop.hbase.replication;
+import org.apache.hadoop.hbase.security.access.PermissionStorage;
+import org.apache.hadoop.hbase.security.visibility.VisibilityConstants;
import org.apache.hadoop.hbase.wal.WAL.Entry;
import org.apache.yetus.audience.InterfaceAudience;
/**
- * Skips WAL edits for all System tables including hbase:meta.
+ * Skips WAL edits for all System tables including hbase:meta except hbase:acl.
*/
@InterfaceAudience.Private
public class SystemTableWALEntryFilter implements WALEntryFilter {
@Override
public Entry filter(Entry entry) {
+ if (
+ entry.getKey().getTableName().equals(PermissionStorage.ACL_TABLE_NAME)
Review Comment:
It is a bit confusing to users that why only hbase:acl can be replicated but
other system tables are not? Please provide more information here, like how do
you plan to use this feature?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
