[
https://issues.apache.org/jira/browse/HBASE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405303#comment-13405303
]
stack commented on HBASE-2730:
------------------------------
Good stuff. I agree w/ Andrew that best place to put it at first at least is
into the dump output (as you have done in your latest patch). Thanks.
FYI, we make patches homed at just under your hbase checkout rather than at the
root of your filesystem. HadoopQA, the patch tester, won't be able to digest
your offered patch otherwise.
In future, rather than do:
{code}
+ if( hrs.isShowQueueDump() ) {
{code}
... and then indent your whole method because of the if clause, I'd do if
(!hrs.isShow...()) return;
Then you'd save an indent.
For the future.
Does this have to be public?
{code}
+ public boolean isShowQueueDump(){
{code}
Maybe it does but it would be sweet if the servlet could read it w/o having to
have a public method (can't the servlet just read this value w/o having to go
to the regionserver? Isn't the Configuration in the servlet context? The
RegionServer already has too much public on it).
Finally, isn't there more you could dump? I'd like to see list of currently
opening regions for example (IIRC, the regionserver has a list of regions its
currently working on opening).
Good stuff Jie.
> Expose RS work queue contents on web UI
> ---------------------------------------
>
> Key: HBASE-2730
> URL: https://issues.apache.org/jira/browse/HBASE-2730
> Project: HBase
> Issue Type: New Feature
> Components: monitoring, regionserver
> Reporter: Todd Lipcon
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: dump.png, hbase-2730-0_94_0.patch,
> hbase-2730-0_94_0.patch
>
>
> Would be nice to be able to see the contents of the various work queues - eg
> to know what regions are pending compaction/split/flush/etc. This is handy
> for debugging why a region might be blocked, etc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
