Apache9 commented on code in PR #4844:
URL: https://github.com/apache/hbase/pull/4844#discussion_r1004051910
##########
dev-support/create-release/release-util.sh:
##########
@@ -678,8 +678,8 @@ function kick_gpg_agent {
# Do maven command to set version into local pom
function maven_set_version { #input: <version_to_set>
local this_version="$1"
- log "${MVN[@]}" versions:set -DnewVersion="$this_version"
- "${MVN[@]}" versions:set -DnewVersion="$this_version" | grep -v "no value" #
silence logs
+ log "${MVN[@]}" versions:set-property -Dproperty=revision
-DnewVersion="$this_version" -DgenerateBackupPoms=false
Review Comment:
Ah, tried locally, seems OK, the -DnewVersion=xxx made me think it is going
to set the version field, but actually, it is used to specify the value of the
property...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
