shahrs87 commented on code in PR #4863:
URL: https://github.com/apache/hbase/pull/4863#discussion_r1018307806
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java:
##########
@@ -467,6 +467,9 @@ public void refreshSources(String peerId) throws
IOException {
ReplicationSourceInterface toRemove = this.sources.put(peerId, src);
if (toRemove != null) {
LOG.info("Terminate replication source for " + toRemove.getPeerId());
+ // Reset sizeOfLogQueue, log will re enqueue to the created new source.
+ toRemove.getSourceMetrics()
Review Comment:
This change will effectively undo
[HBASE-23231](https://issues.apache.org/jira/browse/HBASE-23231) @Apache9
Since you were one of the reviewer on HBASE-23231, do you think it is safe to
do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
