d-c-manning commented on code in PR #4874:
URL: https://github.com/apache/hbase/pull/4874#discussion_r1020621272
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java:
##########
@@ -225,7 +256,7 @@ public static Connection createConnection(Configuration
conf, ExecutorService po
clazz.getDeclaredConstructor(Configuration.class,
ExecutorService.class, User.class);
constructor.setAccessible(true);
return user.runAs((PrivilegedExceptionAction<
- Connection>) () -> (Connection) constructor.newInstance(conf, pool,
user));
+ Connection>) () -> (Connection) constructor.newInstance(conf, pool,
user, identity));
Review Comment:
the metrics don't seem to be tracked via this constructor. They are in the
`AsyncConnection` path, and this is for `Connection`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
