Apache9 commented on code in PR #4882:
URL: https://github.com/apache/hbase/pull/4882#discussion_r1022916804
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:
##########
@@ -961,10 +961,10 @@ public List<KeyValueScanner> getScanners(boolean
cacheBlocks, boolean usePread,
storeFilesToScan =
this.storeEngine.getStoreFileManager().getFilesForScan(startRow,
includeStartRow, stopRow, includeStopRow);
memStoreScanners = this.memstore.getScanners(readPt);
+ storeFilesToScan.stream().forEach(f->f.getReader().incrementRefCount());
Review Comment:
Then there is no problem for the old code either? Since we are under the
lock? I do not fully get the point why here we could fix the problem? Mind
adding more comment in the code? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
