[ 
https://issues.apache.org/jira/browse/HBASE-27486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Moran updated HBASE-27486:
--------------------------
    Description: 
MetricsTableLatenciesImpl  histogramsByTable only put but not remove.Maybe we 
should remove it when table disabled.

supplement:

MetricsTableQueryMeterImpl metersByTable has the same 
problem.RegionServerTableMetrics and MetricsTable are a little strange.Maybe 
can merge into a single.
{code:java}
# org.apache.hadoop.hbase.regionserver.MetricsRegionServer

private RegionServerTableMetrics tableMetrics;
private final MetricsTable metricsTable;

MetricsRegionServer(MetricsRegionServerWrapper regionServerWrapper,
  MetricsRegionServerSource serverSource, RegionServerTableMetrics tableMetrics,
  MetricsTable metricsTable, MetricsUserAggregate userAggregate) {
  this.regionServerWrapper = regionServerWrapper;
  this.serverSource = serverSource;
  this.tableMetrics = tableMetrics;
  this.metricsTable = metricsTable;
  this.userAggregate = userAggregate;
} {code}
 

  was:
MetricsTableLatenciesImpl  histogramsByTable only put but not remove。Maybe we 
should remove it when table disabled。

 
 


> HTable MetricsTableLatencies not remove trigger memory leak 
> ------------------------------------------------------------
>
>                 Key: HBASE-27486
>                 URL: https://issues.apache.org/jira/browse/HBASE-27486
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics, regionserver
>    Affects Versions: 2.0.0
>            Reporter: Moran
>            Priority: Major
>
> MetricsTableLatenciesImpl  histogramsByTable only put but not remove.Maybe we 
> should remove it when table disabled.
> supplement:
> MetricsTableQueryMeterImpl metersByTable has the same 
> problem.RegionServerTableMetrics and MetricsTable are a little strange.Maybe 
> can merge into a single.
> {code:java}
> # org.apache.hadoop.hbase.regionserver.MetricsRegionServer
> private RegionServerTableMetrics tableMetrics;
> private final MetricsTable metricsTable;
> MetricsRegionServer(MetricsRegionServerWrapper regionServerWrapper,
>   MetricsRegionServerSource serverSource, RegionServerTableMetrics 
> tableMetrics,
>   MetricsTable metricsTable, MetricsUserAggregate userAggregate) {
>   this.regionServerWrapper = regionServerWrapper;
>   this.serverSource = serverSource;
>   this.tableMetrics = tableMetrics;
>   this.metricsTable = metricsTable;
>   this.userAggregate = userAggregate;
> } {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to