[
https://issues.apache.org/jira/browse/HBASE-27379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635120#comment-17635120
]
Hudson commented on HBASE-27379:
--------------------------------
Results for branch branch-2.4
[build #460 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/460/]:
(/) *{color:green}+1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/460/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/460/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/460/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/460/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> numOpenConnections metric is one less than the actual
> ------------------------------------------------------
>
> Key: HBASE-27379
> URL: https://issues.apache.org/jira/browse/HBASE-27379
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 2.0.0
> Reporter: Moran
> Assignee: Moran
> Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> In HBASE-17263，serverChannel add to allChannels，so NumOpenConnections exclude
> serverChannel from the count.
> {code:java}
> public NettyRpcServer(final Server server, final String name,
> final List<BlockingServiceAndInterface> services,
> final InetSocketAddress bindAddress, Configuration conf,
> RpcScheduler scheduler) throws IOException {
> super(server, name, services, bindAddress, conf, scheduler);
> ...
> try {
> serverChannel = bootstrap.bind(this.bindAddress).sync().channel();
> LOG.info("NettyRpcServer bind to address=" + serverChannel.localAddress()
> + ", hbase.netty.rpc.server.worker.count=" + workerCount
> + ", useEpoll=" + useEpoll);
> allChannels.add(serverChannel);
> } catch (InterruptedException e) {
> throw new InterruptedIOException(e.getMessage());
> }
> ...
> }
> @Override
> public int getNumOpenConnections() {
> // allChannels also contains the server channel, so exclude that from the
> count.
> return allChannels.size() - 1;
> }{code}
> In HBASE-17263，serverChannel not add to allChannels，so NumOpenConnections is
> one less than the actual.
> {code:java}
> public NettyRpcServer(Server server, String name,
> List<BlockingServiceAndInterface> services,
> InetSocketAddress bindAddress, Configuration conf, RpcScheduler scheduler)
> throws IOException {
> ...
> try {
> serverChannel = bootstrap.bind(this.bindAddress).sync().channel();
> LOG.info("NettyRpcServer bind to address=" +
> serverChannel.localAddress());
> } catch (InterruptedException e) {
> throw new InterruptedIOException(e.getMessage());
> }
> ...
> } {code}
> In HBASE-21610, I think it's actually influenced by this bug.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
