taklwu commented on code in PR #4891:
URL: https://github.com/apache/hbase/pull/4891#discussion_r1028805044
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java:
##########
@@ -59,15 +61,28 @@ public class MetricsRegionWrapperImpl implements
MetricsRegionWrapper, Closeable
private long maxCompactionQueueSize;
private Map<String, Long> readsOnlyFromMemstore;
private Map<String, Long> mixedReadsOnStore;
+ private Map<Integer, Long> storeFilesAccessedDaysAndSize;
+ private int[] storeFilesAccessedDaysThresholds;
private ScheduledFuture<?> regionMetricsUpdateTask;
+ public static long ONE_DAY_MS = 24 * 3600 * 1000;
+ public static final String STOREFILES_ACCESSED_DAYS_THRESHOLDS =
+ "hbase.region.storefiles.accessed.days.thresholds";
+ public static final int[] STOREFILES_ACCESSED_DAYS_THRESHOLDS_DEFAULT = { 7,
30, 90 };
Review Comment:
One more question, if we are using cache / bucket cache heavily, will this
metric retain at the time the store file flushes or opened for cache?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
