[
https://issues.apache.org/jira/browse/HBASE-27503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637190#comment-17637190
]
Duo Zhang commented on HBASE-27503:
-----------------------------------
I'm OK for this change.
But while opening a PR, please also send an email to dev and user mailing list
to mention this change. I'm not sure if some users in the community will rely
on this behavior while specifying the GC_OPTS.
> Support replace <FILE-PATH> in GC_OPTS for ZGC
> ----------------------------------------------
>
> Key: HBASE-27503
> URL: https://issues.apache.org/jira/browse/HBASE-27503
> Project: HBase
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 2.4.15
> Reporter: Moran
> Priority: Minor
>
> HBase support replace -Xloggc:<FILE-PATH> for G1 or CMS。ZGC changed the
> format，like this：
> {code:java}
> -Xlog:safepoint,classhisto*=trace,age*,gc*=info:file=<FILE-PATH>:time,tid,tags:filecount=1,filesize=500M{code}
> Can we only replace <FILE-PATH> instead of -Xloggc:<FILE-PATH> to support
> ZGC？
> [https://github.com/apache/hbase/blob/master/bin/hbase-daemon.sh#L174]
> {code:java}
> if [ -n "$SERVER_GC_OPTS" ]; then
> export
> SERVER_GC_OPTS=${SERVER_GC_OPTS/"-Xloggc:<FILE-PATH>"/"-Xloggc:${HBASE_LOGGC}"}
> fi
> if [ -n "$CLIENT_GC_OPTS" ]; then
> export
> CLIENT_GC_OPTS=${CLIENT_GC_OPTS/"-Xloggc:<FILE-PATH>"/"-Xloggc:${HBASE_LOGGC}"}
> fi {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
