2005hithlj commented on PR #4732:
URL: https://github.com/apache/hbase/pull/4732#issuecomment-1332557103

   @sunhelly 
   I apply your patch, and it's OK to run UTs in my local environment. You can 
change the configuration of hbase.server.useip.enabled to false in 
TestMasterUseIp/TestRegionServerUseIp to see whether the problem is caused by 
my PR.
   
   In addition, if hbase.unsafe.regionserver.hostname/hbase.master.hostname is 
not null, even if hbase.server.useip.enabled is true, useThisHostnameInstead 
will work. If hbase.unsafe.regionserver.hostname/hbase.master.hostname is null, 
and hbase.server.useip.enabled is true, the Master and RegionServers info saved 
in meta and ZK are exposed to the client in the form of IP, which is the 
purpose of my PR(please see 
[HBASE-27489](https://issues.apache.org/jira/browse/HBASE-27489) for details). 
This logic seems to be all right.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to