[
https://issues.apache.org/jira/browse/HBASE-27539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-27539:
-----------------------------
Description:
Both {{StoreFileReader}} and {{StoreFileInfo}} have a {{refCount}}, and the
{{refCount}} is currently used in three main ways:
* When a new {{StoreFileScanner}} is created or close, it increases or
decreases the {{StoreFileReader.refCount}}.
* When {{CompactedHFilesDischarger}} checks a {{HStoreFile}} whether it could
be deleted, it check the {{StoreFileInfo.refCount}}.
* When {{HStore.getScanners}} gets {{HStoreFile}} from {{StoreFileManager}}, it
increases or decreases the {{StoreFileInfo.refCount}}.
The problem here is {{StoreFileReader.refCount}} is copied from the
{{StoreFileInfo.refCount}} and the inconsistent usage of the {{refCount}}
making the code somewhat hard to understand and causing trace the resource race
problems such as HBASE-27484 and HBASE-27519 somewhat difficult. I suggest we
should unify these two {{refCount}} and just use {{StoreFileInfo.refCount}}
was:
Both {{StoreFileReader}} and {{StoreFileInfo}} have a {{refCount}}, and the
{{refCount}} is currently used in three main ways:
* When a new {{StoreFileScanner}} is created or close, it increases or
decreases the {{StoreFileReader.refCount}}.
* When {{CompactedHFilesDischarger}} checks a {{HStoreFile}} whether it could
be deleted, it check the {{StoreFileInfo.refCount}}.
* When {{HStore.getScanners}} gets {{HStoreFile}} from {{StoreFileManager}}, it
increases or decreases the {{StoreFileInfo.refCount}}.
The problem here is {{StoreFileReader.refCount}} is copied from the
{{StoreFileInfo.refCount}} and the inconsistent usage of the {{refCount}}
making the code somewhat hard to understand and causing trace the resource
problem such as HBASE-27484 and HBASE-27519 somewhat difficult. I suggest we
should unify these two {{refCount}} and just use {{StoreFileInfo.refCount}}
> Unify reference count in StoreFileReader and StoreFileInfo
> ----------------------------------------------------------
>
> Key: HBASE-27539
> URL: https://issues.apache.org/jira/browse/HBASE-27539
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0-alpha-3
> Reporter: chenglei
> Priority: Major
>
> Both {{StoreFileReader}} and {{StoreFileInfo}} have a {{refCount}}, and the
> {{refCount}} is currently used in three main ways:
> * When a new {{StoreFileScanner}} is created or close, it increases or
> decreases the {{StoreFileReader.refCount}}.
> * When {{CompactedHFilesDischarger}} checks a {{HStoreFile}} whether it
> could be deleted, it check the {{StoreFileInfo.refCount}}.
> * When {{HStore.getScanners}} gets {{HStoreFile}} from {{StoreFileManager}},
> it increases or decreases the {{StoreFileInfo.refCount}}.
> The problem here is {{StoreFileReader.refCount}} is copied from the
> {{StoreFileInfo.refCount}} and the inconsistent usage of the {{refCount}}
> making the code somewhat hard to understand and causing trace the resource
> race problems such as HBASE-27484 and HBASE-27519 somewhat difficult. I
> suggest we should unify these two {{refCount}} and just use
> {{StoreFileInfo.refCount}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
