[
https://issues.apache.org/jira/browse/HBASE-27233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651082#comment-17651082
]
Hudson commented on HBASE-27233:
--------------------------------
Results for branch branch-2
[build #709 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/709/]:
(/) *{color:green}+1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/709/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/709/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/709/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/709/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read blocks into off-heap if caching is disabled for read
> ---------------------------------------------------------
>
> Key: HBASE-27233
> URL: https://issues.apache.org/jira/browse/HBASE-27233
> Project: HBase
> Issue Type: Improvement
> Reporter: Bryan Beaudreault
> Assignee: Bryan Beaudreault
> Priority: Major
> Labels: patch-available
> Fix For: 3.0.0-alpha-4, 2.5.3
>
>
> Currently we decide whether a disk read {{shouldUseHeap}} based on three
> criteria:
> # If block cache is disabled, return false
> # If block cache is anything other than CombinedBlockCache, return true
> # Otherwise return false for DATA blocks and true for other blocks
> The assumption here is we're making the decision based on which cache the
> block is likely to end up in. But if the read has caching disabled (i.e.
> setCacheBlocks(false)), it won't get into any cache. So we should return
> false in that case too.
> The only caller to {{shouldUseHeap}} in HFileReaderImpl has a boolean
> {{cacheBlock}} available which determines if the read block should attempt to
> be cached. We can pass that boolean into the function. We should probably
> also account for cacheConf.shouldCacheBlockOnRead for the same reason.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
