wchevreuil commented on code in PR #4945: URL: https://github.com/apache/hbase/pull/4945#discussion_r1064492323
########## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java: ########## @@ -107,6 +108,20 @@ private static final Logger LOG = LoggerFactory.getLogger(TransitRegionStateProcedure.class); + public static final String FORCE_REGION_RETAINMENT = "hbase.master.scp.retain.assignment.force"; + + public static final boolean DEFAULT_FORCE_REGION_RETAINMENT = false; + + public static final String FORCE_REGION_RETAINMENT_WAIT = + "hbase.master.scp.retain.assignment.force.wait"; + + public static final long DEFAULT_FORCE_REGION_RETAINMENT_WAIT = 500; Review Comment: A single overall wait time would be less efficient, we would forcibly wait for the whole of the given timeout, even if the RS comes back online much sooner than that. Maybe better leave as this, but put comments on this constant to avoid confusion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
