bbeaudreault commented on code in PR #4937:
URL: https://github.com/apache/hbase/pull/4937#discussion_r1064639625
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/OnlineLogRecord.java:
##########
@@ -261,15 +311,17 @@ public boolean equals(Object o) {
.append(multiServiceCalls, that.multiServiceCalls).append(clientAddress,
that.clientAddress)
.append(serverClass, that.serverClass).append(methodName,
that.methodName)
.append(callDetails, that.callDetails).append(param, that.param)
- .append(regionName, that.regionName).append(userName,
that.userName).isEquals();
+ .append(regionName, that.regionName).append(userName,
that.userName).append(scan, that.scan)
+ .append(multi, that.multi).append(get, that.get).append(mutate,
that.mutate).isEquals();
}
@Override
public int hashCode() {
return new HashCodeBuilder(17,
37).append(startTime).append(processingTime).append(queueTime)
.append(responseSize).append(clientAddress).append(serverClass).append(methodName)
.append(callDetails).append(param).append(regionName).append(userName).append(multiGetsCount)
- .append(multiMutationsCount).append(multiServiceCalls).toHashCode();
+
.append(multiMutationsCount).append(multiServiceCalls).append(scan).append(multi).append(get)
+ .append(mutate).toHashCode();
}
@Override
Review Comment:
do we need to handle these new fields in `toJsonPrettyPrint()` at all? Not
sure how this method is used, but I see special handling at the top of this
class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
