Apache9 commented on code in PR #4916:
URL: https://github.com/apache/hbase/pull/4916#discussion_r1065376444


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java:
##########
@@ -55,6 +55,8 @@ public class TableStateManager {
   private final ConcurrentMap<TableName, TableState.State> tableName2State =
     new ConcurrentHashMap<>();
 
+  private final ConcurrentMap<TableName, Integer> creating = new 
ConcurrentHashMap<>();

Review Comment:
   ConcurrentMap.newKeySet



##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java:
##########
@@ -114,6 +115,7 @@ protected Flow executeFromState(final MasterProcedureEnv 
env, final CreateTableS
           // XXX: this stage should be named as set table enabled, as now we 
will cache the
           // descriptor after writing fs layout.
           setEnabledState(env, getTableName());
+          
env.getMasterServices().getTableStateManager().finishCreating(getTableName());

Review Comment:
   Actually, the sub procedure will be execute after this line has been 
executed, so the solution here can not solve the problem described in the 
issue...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to