ndimiduk commented on code in PR #4954:
URL: https://github.com/apache/hbase/pull/4954#discussion_r1068024563
##########
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/monkies/PolicyBasedChaosMonkey.java:
##########
@@ -151,7 +157,9 @@ public boolean isStopped() {
@Override
public void waitForStop() throws InterruptedException {
- monkeyThreadPool.awaitTermination(1, TimeUnit.MINUTES);
+ if (!monkeyThreadPool.awaitTermination(1, TimeUnit.MINUTES)) {
+ LOG.warn("Some pool threads failed to terminate, {}", monkeyThreadPool);
Review Comment:
Strange. `monkeyThreadPool` is not a daemon pool, so if this termination
fails for some reason, the process can hang. Let me add a forced shutdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
