Apache9 commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1068971919
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java:
##########
@@ -178,16 +179,19 @@ private void decorateConf() {
/**
* Replicate this array of entries directly into the local cluster using the
native client. Only
* operates against raw protobuf type saving on a conversion from pb to pojo.
+ * @param entries WAL entries to be replicated.
+ * @param cells cell scanner for iteration.
* @param replicationClusterId Id which will uniquely identify source
cluster FS client
* configurations in the replication
configuration directory
* @param sourceBaseNamespaceDirPath Path that point to the source cluster
base namespace
* directory
* @param sourceHFileArchiveDirPath Path that point to the source cluster
hfile archive directory
+ * @param rsServerHost regionserver coproc host.
* @throws IOException If failed to replicate the data
*/
public void replicateEntries(List<WALEntry> entries, final CellScanner cells,
String replicationClusterId, String sourceBaseNamespaceDirPath,
- String sourceHFileArchiveDirPath) throws IOException {
+ String sourceHFileArchiveDirPath, RegionServerCoprocessorHost
rsServerHost) throws IOException {
Review Comment:
I mean we should pass RegionServerCoprocessorHost in when creating
ReplicationSink, and store it as the a class field, so we do not need to pass
it everytime when calling replicateEntries...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
