rmdmattingly commented on code in PR #4937:
URL: https://github.com/apache/hbase/pull/4937#discussion_r1085638099
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/OnlineLogRecord.java:
##########
@@ -128,11 +193,52 @@ public int getMultiServiceCalls() {
return multiServiceCalls;
}
+ /**
+ * If {@value
org.apache.hadoop.hbase.HConstants#SLOW_LOG_OPERATION_MESSAGE_PAYLOAD_ENABLED}
is
+ * enabled then this value may be present and should represent the Scan that
produced the given
+ * {@link OnlineLogRecord}. This value should only be present if {@link
#getMulti()},
+ * {@link #getGet()}, and {@link #getMutate()} are empty
+ */
+ public Optional<Scan> getScan() {
+ return scan;
+ }
+
+ /**
+ * If {@value
org.apache.hadoop.hbase.HConstants#SLOW_LOG_OPERATION_MESSAGE_PAYLOAD_ENABLED}
is
+ * enabled then this value may be present and should represent the
MultiRequest that produced the
+ * given {@link OnlineLogRecord}. This value should only be present if
{@link #getScan},
+ * {@link #getGet()}, and {@link #getMutate()} are empty
+ */
+ public Optional<List<Operation>> getMulti() {
+ return multi;
+ }
+
+ /**
+ * If {@value
org.apache.hadoop.hbase.HConstants#SLOW_LOG_OPERATION_MESSAGE_PAYLOAD_ENABLED}
is
+ * enabled then this value may be present and should represent the Get that
produced the given
+ * {@link OnlineLogRecord}. This value should only be present if {@link
#getScan()},
+ * {@link #getMulti()} ()}, and {@link #getMutate()} are empty
+ */
+ public Optional<Get> getGet() {
+ return get;
+ }
+
+ /**
+ * If {@value
org.apache.hadoop.hbase.HConstants#SLOW_LOG_OPERATION_MESSAGE_PAYLOAD_ENABLED}
is
+ * enabled then this value may be present and should represent the Mutation
that produced the
+ * given {@link OnlineLogRecord}. This value should only be present if
{@link #getScan},
+ * {@link #getMulti()} ()}, and {@link #getGet()} ()} are empty
+ */
+ public Optional<Mutation> getMutate() {
+ return mutate;
+ }
Review Comment:
This is good advice for sure. I've mulled it over a little, and I'm not sure
what I'd change at this level. Please let me know if you have any ideas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
