[
https://issues.apache.org/jira/browse/HBASE-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680459#comment-17680459
]
Hudson commented on HBASE-26300:
--------------------------------
Results for branch branch-2
[build #725 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/725/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/725/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/725/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/725/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/725/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Skip archived master wals during incremental backups
> ----------------------------------------------------
>
> Key: HBASE-26300
> URL: https://issues.apache.org/jira/browse/HBASE-26300
> Project: HBase
> Issue Type: Bug
> Components: backup&restore
> Reporter: Bryan Beaudreault
> Assignee: Jarryd Lee
> Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> I've been reading through the incremental backup implementation in master
> branch to see how it handled some scenarios our own internal incremental
> backup process has to handle. One such failure we recently encountered as
> part of our ongoing hbase2 upgrade is the new $masterlocalwal$ suffixed files
> in the oldWALs dir. Our parsing of the WAL files assumed that the last part
> of the file name would be a timestamp, which is not the case for these
> MasterRegion WALs.
> I see [IncrementalBackupManager excludes
> ProcV2Wals|https://github.com/apache/hbase/blob/master/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java#L104-L117],
> but I think that was replaced in
> https://issues.apache.org/jira/browse/HBASE-24408 with a MasterRegion. The
> new MasterRegion uses normal WALs, but archives them with a suffix
> "$masterlocalwal$".
> I believe this would fail [around line 222 of
> IncrementalBackupManager|https://github.com/apache/hbase/blob/master/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java#L222],
> because
> [BackupUtils.getCreationTime|https://github.com/apache/hbase/blob/master/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java#L383-L390]
> similarly expects the file names to end with a timestamp.
> Unfortunately I am not set up to run master branch or test the backup/restore
> functionality, but I wanted to log this because I happened to stumble upon it.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
