[
https://issues.apache.org/jira/browse/HBASE-27595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681277#comment-17681277
]
tianhang tang edited comment on HBASE-27595 at 1/27/23 11:02 AM:
-----------------------------------------------------------------
[~zhangduo]Need your help: )
I think it is reasonable to delete this piece of code, because the dependency
version is different, and the implementation itself is a little tricky; but on
the other hand, first of all, it will not cause any problems. Then if people
want to change the Hadoop version and compile and run some UTs by themselves,
it can still be useful.
Not sure what the community thinks.
was (Author: tangtianhang):
[~zhangduo]Need your help: )
I think it is reasonable to delete this piece of code, because the dependency
version is different, and the implementation itself is a little tricky; but on
the other hand, first of all, it will not cause any problems. Then if people
want to change the Hadoop version and compile and run some UTs by themselves,
it can still be useful.
Not sure what the community thinks.
> ThreadGroup is removed since Hadoop 3.2.4
> -----------------------------------------
>
> Key: HBASE-27595
> URL: https://issues.apache.org/jira/browse/HBASE-27595
> Project: HBase
> Issue Type: Test
> Reporter: tianhang tang
> Assignee: tianhang tang
> Priority: Minor
>
> Found lots of WARNING in UT log:
> {code:java}
> 2023-01-26T05:26:18,869 WARN [FsDatasetAsyncDiskServiceFixer]
> hbase.HBaseTestingUtil$FsDatasetAsyncDiskServiceFixer(617): failed to reset
> thread pool timeout for FsDatasetAsyncDiskService
> java.lang.NoSuchFieldException: threadGroup
> at java.lang.Class.getDeclaredField(Class.java:2411) ~[?:?]
> at
> org.apache.hadoop.hbase.HBaseTestingUtil$FsDatasetAsyncDiskServiceFixer.run(HBaseTestingUtil.java:609)
> ~[test-classes/:?]
> {code}
> FsDatasetAsyncDiskServiceFixer is introduced by
> [HBASE-27148|https://issues.apache.org/jira/browse/HBASE-27148], to prevent
> unexpected kill.
> But Hadoop 3.2.4 has fixed this issue
> [HDFS-16586|https://issues.apache.org/jira/browse/HDFS-16586] and for now
> HBase use 3.2.4 on branch master.
> So I think maybe can remove these code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
