frostruan commented on PR #4997: URL: https://github.com/apache/hbase/pull/4997#issuecomment-1407590603
Thanks for the invitation Duo @Apache9 I think it depends on whether we want to keep the old metric information when refresh replication source. If so, then I think this is a great improvement, what only needs to be done is to remind the user of our behavior change in the release note. And also, we may need to change the clearMetric flag to false to avoid calling singleSourceSource.clear() in https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java#L470 ? What do you think ? @mosmeh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
