Apache9 commented on code in PR #4999:
URL: https://github.com/apache/hbase/pull/4999#discussion_r1091426181
##########
hbase-shaded/hbase-shaded-testing-util/pom.xml:
##########
@@ -151,6 +151,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
+ <version>${hadoop.version}</version>
Review Comment:
No, we should not add version in the sub module's pom files, especially for
hadoop, as we will depend on hadoop in multiple sub modules. Let's fix the
hadoop-common version problem first, and then merge #5000, as the problem for
#5000 only affects master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
