[ 
https://issues.apache.org/jira/browse/HBASE-27216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684170#comment-17684170
 ] 

Duo Zhang commented on HBASE-27216:
-----------------------------------

Oh, there is a problem that, in ReplicationSourceManager, when claiming 
replication queue, we assume that all the wals are under the oldWALs directory. 
But for replication sync up, SCP may have not been finished yet, so it is 
possible that the wal files we want to replicate are still under the WALs 
directory...

For me, I prefer we add a new parameter for the claimQueue method in 
ReplicationSourceManager, when it is called by ReplicationSyncUp, we set it to 
true, then we will also list WALs directory.

Thanks.

> Revisit the ReplicationSyncUp tool
> ----------------------------------
>
>                 Key: HBASE-27216
>                 URL: https://issues.apache.org/jira/browse/HBASE-27216
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Replication, tooling
>            Reporter: Duo Zhang
>            Assignee: Liangjun He
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to